From 6e319e82ea514b50a2747de5a34ac5449836d877 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Thu, 15 Aug 2024 19:45:38 -0600
Subject: [PATCH] add fix & test for humminbird route writer. (#1324)

The missing initialization was introduced in 824e01d.
---
 humminbird.cc                           |   2 +-
 reference/route/humminbird_gpsbabel.hwr | Bin 0 -> 3504 bytes
 testo.d/humminbird.test                 |  16 ++++++++++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 reference/route/humminbird_gpsbabel.hwr

diff --git a/humminbird.cc b/humminbird.cc
index 3d66cc058..f829cc796 100644
--- a/humminbird.cc
+++ b/humminbird.cc
@@ -805,7 +805,7 @@ HumminbirdFormat::humminbird_rte_head(const route_head* rte)
 {
   humrte = nullptr;
   if (!rte->rte_waypt_empty()) {
-    humrte = new humminbird_rte_t;
+    humrte = new humminbird_rte_t();
   }
 }
 
diff --git a/reference/route/humminbird_gpsbabel.hwr b/reference/route/humminbird_gpsbabel.hwr
new file mode 100644
index 0000000000000000000000000000000000000000..f2f5a2bbad0d11454615f63f0c71eee7f639f86a
GIT binary patch
literal 3504
zcmcJRTWnNC7{@=_Qb6TSvB<4OETuquE<1B}DHnI?c3XP7v)xMpWh0lEs4qYwUS3tK
zKA?#YUg84@A<=k^`e1xC;-xWB9v}pKGHEm@i4WQ+YO?-k&YbC)^_fZ9rtNRP@BdwA
zT3To`;mpI=uK5$MH>TVzBqmNWhjaONd0Hd`Kr(}!hZ~J4=N6a?U;+iiOp9h_-`wAr
z@}33r1amUBoz|qUf!|3~k25#rS$5iDU-cIFVk9PyF_+nP<{PH9G1Y&L!~>U^=cOz=
z?H2PciTXI0jKwUlm>Cj>mov||<60OoQGT39;Oi{&nC)wkwsT|p3^cDIaqtqDwB_p#
z%g$NYd5L-4wsWV^(*`@opyzoofuk*{THIwZpMdF>409rHidk&w`J2RpSD6=ZS9?>;
zk|g790CPbyzMHVKH0jF?;OlcRc3jI0GavnP6?uM|d1*V(%OghT@CJz^A@hUO@Mt+N
zy(v8_jGcDaSwrGzFBrS-D`Q6Xp}!YBc7{8S&8$lL@?mEpFPU6eoAcFSG1DYUE_dA2
zcs@HM4ro2AEni?NUEFEvpSxqGzNj(9UL_%BxWoJ?gW67~Vdgca_%QUm&70?Ijm7K+
zGYiJ<!+R{|ANXqLPN1u$eXTVN!Ph$^ihW>gJ?jhuJ;7<j{vvnMb|0>f8JXwQ7l{2h
zcYWPq+Si7dk#m}Q8O${>ww{fKk@<NK^ZpZeoAT3@WcasWQrvBdtJ^RO5!YMT2_Jy5
z>%PfiejssR2^c$v_r{Eji=$qLZgDTL_YXE=wCn0JheyHu`#<JB!$>`^VJ@zMvFD;k
zGio0O{n!cLb1!Y@aEry{u@iQJvFp{FWcYQ=*A+1Kd~HqY2?X?<;$Fs%z0WY1FaJD=
zV{P2`Y|YyYvjFwNd>s+oZ`yU+4Ffx@7jt?ZOyKD(s#)G)F{i+MB$+re#q=8nzW7NJ
z56y7DsaFRKgIcf-5`()r_w8OqMice=n8f%+o(b&ypeq%lYQfi%2(R!=Q+}Xd+mU)|
z(A=NPXUkn9qhT2DC{!k5oUg&8VP`s*55xRqVz)q@WTIW?KZ;o{VYk@5%3?cpd4FBP
z?!Ab6hv&+pLj`Opl^=XU>%m@ieubWl+=mu}3Tp=Q#j)or*SVW^_mxGZ5^F|<=NN{#
z#7XX?Jc~iL=HYIZ2Ri}x^5MURvgNT65r!q9_3Q+Ldv36^j=hm;hp(I5_1q!sO!+yb
zdC)M3%iW9_oMCQ|v6x+kL0sM;^z%99Wo%}*VdP!F5c@J2yJcsOVPvnm=%1(1W4^`g
zH4NsIeTu!Y8vBP?%>7`XA8|qRjz2M{?-#PwymeP*4TF1m;5X!FRx!G&D)yXV<UP1e
z-h+zKQ>d7IhLLfBIr@rXbhj!7+0=SuA3B)Ro09SLW>pM&WR6MiLI3=s7(E$^8IG8!
z4>|G^ekK{To;r#tXgliN!kz>3hh*YrRm@22%lQU+K14r%hdU(*MM1V$RQJ)Ooq@}!
z`(?cA(#32sUqbGbo&B+$x_sOGj2sr_yG7(G)hzO&n6acCy!nLaDP@b*k@CLmWIPub
zMiqPX*21nk^dsI{Ua3|tg)uX3e92nKdOd?TNpJwMm1E6C!$42}HPq`d%wVQ068((c
z*Ljw93SheA`^RERG2?uNxK5BLcQS|B%!FaSL=M%xQyIzUOT!|R!=qw{Fzrj;DI=)q
zlNFII<-|dm=7>SY=VEue(LW_Q7nN!`pGC~dPBmhpx(~cTqP7RMNL6a%<D>YWVrsE3
zSyN{nW_can*iJQDL<NXiTj>S)69-$GD7oY0@9OwepfT#8m9&cR_J^<%)u@%K)JCJU
zh(cOIi)lYCrDe37R#1idXglqIMUQ%ED{Y}3+C<&7k-BIDt*6zn)B%eH!j_GW(jfze
nZ27Hx;`HMW>w8B2u1*zRZ}U+)l!Al~qf$E`q<FM$o0|Us`Wh(B

literal 0
HcmV?d00001

diff --git a/testo.d/humminbird.test b/testo.d/humminbird.test
index 3604bc6bb..eb143863a 100644
--- a/testo.d/humminbird.test
+++ b/testo.d/humminbird.test
@@ -7,6 +7,21 @@ gpsbabel -i humminbird -f ${REFERENCE}/humminbird.hwr -o humminbird -F ${TMPDIR}
 bincompare ${REFERENCE}/humminbird.hwr ${TMPDIR}/humminbird.hwr
 gpsbabel -i humminbird -f ${REFERENCE}/route/humminbird.hwr -o gpx -F ${TMPDIR}/humminbird~hwr.gpx
 compare ${REFERENCE}/route/humminbird~hwr.gpx ${TMPDIR}/humminbird~hwr.gpx
+
+# The provenance of humminbird.hwr is unclear.
+# The routes have timestamps
+# 48 a8 59 72 (Sun Aug 17 2008 17:01:38 GMT+0000)
+# 48 a8 5a 77 (Sun Aug 17 2008 17:05:59 GMT+0000)
+# 48 a8 5a 80 (Sun Aug 17 2008 17:06:08 GMT+0000)
+# which suggests they may be real.
+# The unused entries in the points array of the route headers appear to be random.
+# To add regresssion for our writer we generated a corresponding hwr file with GPSBABEL_FREEZE_TIME=y
+# gpsbabel -i humminbird -f reference/route/humminbird.hwr -o humminbird -F reference/route/humminbird_gpsbabel.hwr
+# This has zeroed timestamps and zeroed unused entries in the points arrays.
+gpsbabel -i humminbird -f ${REFERENCE}/route/humminbird_gpsbabel.hwr -o humminbird -F ${TMPDIR}/humminbird_gpsbabel~hwr.hwr
+compare ${REFERENCE}/route/humminbird_gpsbabel.hwr ${TMPDIR}/humminbird_gpsbabel~hwr.hwr
+
+#
 #
 # Humminbird tracks
 #
@@ -27,3 +42,4 @@ compare ${REFERENCE}/humminbird-rte-v2~gpx.gpx ${TMPDIR}/humminbird-rte-v2~gpx.g
 
 gpsbabel -i humminbird -f ${REFERENCE}/humminbird-rte-v3.hwr  -o gpx,humminbirdextensions=1 -F ${TMPDIR}/humminbird-rte-v3~gpx.gpx
 compare ${REFERENCE}/humminbird-rte-v3~gpx.gpx ${TMPDIR}/humminbird-rte-v3~gpx.gpx 
+
-- 
2.30.2